Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate based number limits #1507

Merged
merged 1 commit into from
May 5, 2020
Merged

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented May 1, 2020

Issue #, if available:
Fix #1446
Description of changes:

  • Add rate based limit min/max values to wafv2 WebAcl and RuleGroups

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #1507 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1507   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files         156      156           
  Lines        8782     8782           
  Branches     2101     2101           
=======================================
  Hits         7688     7688           
  Misses        657      657           
  Partials      437      437           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fa709...e70f068. Read the comment docs.

@kddejong kddejong force-pushed the fix/1446 branch 2 times, most recently from 411a8e8 to e308ab4 Compare May 5, 2020 15:19
@kddejong kddejong merged commit 77be715 into aws-cloudformation:master May 5, 2020
@kddejong kddejong deleted the fix/1446 branch May 5, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::WAFv2::WebACL RateBasedStatement Limit Validation
2 participants