add rule E3017 to check when a prop is required based on a value

[kddejong]

Issue #, if available:
#1744
Description of changes:

• Add rule E3017 to validate when a property is required based on another property having a certain value

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[PatMyron]

Think investigating similar rules/requests will be helpful:
CloudWatch, DynamoDB, ECS, EC2, Lambda, RDS, RDS, Route53, Route53, Route53, StepFunctions

Something to note is that quite a few of them are the opposite: a certain property cannot be specified based on the value of another property. Might be useful to support both formats:

# just example possibilities for discussion
not StartingPosition if AWS::Lambda::EventSourceMapping.EventSourceArn == arn:aws*:(kinesis|kafka|dynamodb):*
!StartingPosition if AWS::Lambda::EventSourceMapping.EventSourceArn == arn:aws*:(kinesis|kafka|dynamodb):*

this is also very similar to cfn-guard WHEN checks (aws-cloudformation/cloudformation-guard#52)

[PatMyron]

missing support for other partitions

Suggested change

	"Regex": "arn:aws:(kinesis|kafka|dynamodb):*",
	"Regex": "arn:aws*:(kinesis|kafka|dynamodb):*",

[PatMyron]

@kddejong sorry, got confused by that trailing wildcard. Should be something like this instead:

+                    "Regex": "arn:aws.*:(kinesis|kafka|dynamodb):",

+                    "Regex": "arn:aws.*:(kinesis|kafka|dynamodb):.*",

[kddejong]

Oops. Resolved it here #1759

[kddejong]

For tracking after this PR is merged I will evaluate if these rules can be deleted and moved to this rule.
https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/resources/rds/AuroraScalingConfiguration.py
https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/resources/rds/AuroraDBInstanceProperties.py
https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/resources/route53/HealthCheck.py
https://github.com/aws-cloudformation/cfn-python-lint/blob/master/src/cfnlint/rules/resources/dynamodb/BillingMode.py

[kddejong]

@PatMyron I'm going to look at another rule for doing the opposite check because I'm finding use cases where it could be valuable.