refactor: move list of stateful resource types to data file #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDK would like to use the same data that cfn-lint is using to help our code generation. This change moves the list of stateful resource types to a JSON file, which is easier to parse for the CDK build process than a Python source file. This will help keep the source of truth in sync between the two projects. This is not supposed to be the be-all-and-end-all solution of integration between the two projects. I'm aware it's quite ad-hoc; but let's try something low-friction and see how it goes?
rix0rrr
force-pushed
the
data-driven-statefulness
branch
from
1fdfd97
to
f413c9b
Compare
johnttompkins
approved these changes
Feb 10, 2021
direvus
pushed a commit
to direvus/cfn-python-lint
that referenced
this pull request
Apr 12, 2021
…dformation#1897) The CDK would like to use the same data that cfn-lint is using to help our code generation. This change moves the list of stateful resource types to a JSON file, which is easier to parse for the CDK build process than a Python source file. This will help keep the source of truth in sync between the two projects. This is not supposed to be the be-all-and-end-all solution of integration between the two projects. I'm aware it's quite ad-hoc; but let's try something low-friction and see how it goes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-cdk#12920
The CDK would like to use the same data that cfn-lint is using to
help our code generation.
This change moves the list of stateful resource types to a JSON file,
which is easier to parse for the CDK build process than a Python source
file. This will help keep the source of truth in sync between the
two projects.
This is not supposed to be the be-all-and-end-all solution of
integration between the two projects. I'm aware it's quite ad-hoc;
but let's try something low-friction and see how it goes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.