Ignore Mapping key issues when using Fn::Transform #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatMyron
reviewed
May 21, 2021
| @@ -35,7 +35,7 @@ def check_key(self, key, path): | |||
| if not isinstance(key, six.string_types): | |||
| message = 'Mapping key ({0}) has to be a string.' | |||
| matches.append(RuleMatch(path[:], message.format(key))) | |||
| elif not re.match('^[a-zA-Z0-9.-]{1,255}$', key): | |||
| elif not re.match('^[a-zA-Z0-9.-]{1,255}$', key) and key != 'Fn::Transform': | |||
There was a problem hiding this comment.
I was more filtering this out because we didn't flag this as a failure, then we started flagging it as a failure so wanted to bring it back to where it was.
Interesting. It could be possible. We would want to evaluate the start and end mark of the finding is within the transform so if someone is doing a one line json document we don't filter out everything.
As we continue to evaluate the need of credentials we may be able to test resolving the Transform as well. Your option would be a great way to not have an issue if we can't resolve credentials. We may be able to implement your idea fairly easily. I may test it out today actually :)
PatMyron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #2016
Description of changes:
E7003By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.