Fix method name collisions for getProperties() #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianlaoaws
approved these changes
Jan 10, 2024
reza-aws
approved these changes
Jan 10, 2024
akshayrane
approved these changes
Jan 10, 2024
rpdutt
approved these changes
Jan 10, 2024
|
@akshayrane @brianlaoaws @reza-aws @rpdutt I'm converting this PR to a draft to explore the possibility to have a resolution dedicated to hooks, as this plugin is also used for resource types whose generated classes are also processed by the same logic that this PR updates. |
mrinaudo-aws
requested review from
akshayrane,
brianlaoaws,
reza-aws and
rpdutt
brianlaoaws
approved these changes
Jan 10, 2024
rpdutt
approved these changes
Jan 10, 2024
minhphuong98
approved these changes
Jan 10, 2024
reza-aws
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix method name collisions for
getProperties()when a target resource type has aPropertiesproperty defined, and Lombok-generated getters (and setters) are namedgetProperties()(andsetProperties(), respectively), whereas the former collides withgetProperties()already defined forResourceHookTarget.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.