Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research why the default validation method didn't catch errors in the example schema #66

Closed
tobywf opened this issue Oct 25, 2018 · 1 comment
Assignees

Comments

@tobywf
Copy link
Contributor

tobywf commented Oct 25, 2018

The RefInliner change of #56 exposed some errors in the example schemas. Why were these not caught using the normal validation method? Did we set it up wrong, so it doesn't do recursive validation?

tobywf added a commit that referenced this issue Oct 25, 2018
This is inefficient when only one item from a large schema is inlined, but this way inlined schemas are still valid (my previous way of flattening refs included `/` in the property names). Schemas are inlined under a reserved "remote" property at the same level of "definitions" and "properties". As a side effect, RefRenamer no longer has to worry about clobbering keys, so that code was simplified.

Had to fix example schemas - need to do more research on why this wasn't caught earlier (#66).
@tobywf
Copy link
Contributor Author

tobywf commented Nov 20, 2018

Need to either resolve refs before we validate (issue with circular refs?), or set up the metaschema/schema/data dynamic correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant