Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::ElasticLoadBalancingV2::TargetGroup - ProtocolVersion #713

Open
intercept6 opened this issue Dec 9, 2020 · 8 comments
Open

AWS::ElasticLoadBalancingV2::TargetGroup - ProtocolVersion #713

intercept6 opened this issue Dec 9, 2020 · 8 comments
Labels

Comments

@intercept6
Copy link

intercept6 commented Dec 9, 2020

2. Scope of request

AWS::ElasticLoadBalancingV2::TargetGroup-ProtocolVersion can create resources via API, but not via CloudFormation.

ElasticLoadBalancingV2 CreateTargetGroup now supports the ProtocolVersion parameter for gRPC or HTTP2. CloudFormation needs support for this as well.

3. Expected behavior

In Create, it should include the ProtocolVersion, like the console.

5. Helpful Links to speed up research and evaluation

6. Category (required) - Will help with tagging and be easier to find by other users to +1

  1. Networking & Content (VPC, Route53, API GW,...)
@universam1
Copy link

When will this be available?

@dennisroche
Copy link

I have created a custom resource to do this in the meantime; if anyone is interested i'm happy to share it.

@OSullivanM2
Copy link

I have created a custom resource to do this in the meantime; if anyone is interested i'm happy to share it.

If you wouldn't mind please Dennis. Thanks

@akunszt
Copy link

akunszt commented Feb 11, 2021

@dennisroche I would be very happy to see that too. I tried to create my own but it looks like the API doesn't allow to modify the Protocol Version on an existing TargetGroup at all.

@dennisroche
Copy link

dennisroche commented Feb 12, 2021

I would be very happy to see that too. I tried to create my own but it looks like the API doesn't allow to modify the Protocol Version on an existing TargetGroup at all.

Update requires Replacement, i.e. ProtocolVersion can only set on creation.

@dennisroche
Copy link

I have created a minimal example of HTTP2 Target Group custom resource https://gist.github.com/dennisroche/287915ca6a0874157d71b0903ec3999b

@akunszt
Copy link

akunszt commented Feb 12, 2021

Luckily it turned out - with the help of the AWS Support - that it's only a documentation issue. You can use the ProtocolVersion in the CloudFormation template. For example this worked for me:

---
AWSTemplateFormatVersion: 2010-09-09
Resources:
  MyALBTargetGroup:
    Type: 'AWS::ElasticLoadBalancingV2::TargetGroup'
    Properties:
      HealthCheckIntervalSeconds: 30
      HealthCheckPath: /AWS.ALB/healthcheck
      HealthCheckPort: '8443'
      HealthCheckProtocol: HTTP
      ProtocolVersion: HTTP2
      HealthCheckTimeoutSeconds: 5
      HealthyThresholdCount: 10
      Matcher:
        HttpCode: 200-299
      Port: 8443
      Protocol: HTTP
      UnhealthyThresholdCount: 2
      VpcId: vpc-XXX

@WaelA WaelA added the Coverage label Aug 3, 2021
@WaelA WaelA changed the title AWS::ElasticLoadBalancingV2::TargetGroup-ProtocolVersion AWS::ElasticLoadBalancingV2::TargetGroup - ProtocolVersion Aug 4, 2021
@github-project-automation github-project-automation bot moved this to Researching in coverage-roadmap Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Researching
Development

No branches or pull requests

7 participants