(elasticloadbalancingv2): cant set protocol version on alb #12869

danilobuerger · 2021-02-04T18:53:36Z

According to https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-protocol-version I am able to set the protocol version to http1, http2 or grpc. The console also supports this. I am unable to set that via cdk.

Reproduction Steps

None.

What did you expect to happen?

Can specify protocol version.

What actually happened?

Can't specify protocol version. Always created with http1

Environment

CDK CLI Version : 1.88.0
Language (Version): Typescript

This is 🐛 Bug Report

njlynch · 2021-02-08T11:45:49Z

Needs CloudFormation support. See aws-cloudformation/cloudformation-coverage-roadmap#713

danilobuerger · 2021-02-12T08:22:36Z

@njlynch according to the latest comment in the issue (aws-cloudformation/cloudformation-coverage-roadmap#713 (comment)) it is actually supported but just undocumented.

ChristopheBougere · 2021-03-07T19:22:33Z

Correct me if I'm wrong, but it looks like it has been added to the CDK CFN specs: https://github.com/aws/aws-cdk/pull/13249/files#diff-db0dab61b544f58bb3162b9fd5e07d5b8450aff43a5b1f81415366e622c95991R72
Any chance to get this integrated into CDK soon?

jesperrix · 2021-03-12T09:11:24Z

Any news on when this gets integrated into CDK?
Right now we are manually creating target groups for our services, would really appreciate having CDK integration soon.

njlynch · 2021-03-12T10:34:01Z

I can't give a timeline for when this will be integrated in. If someone is interested in creating a PR, I'd be happy to work with you to get it merged in.

The work would involve defining a new enum for the protocol version, adding an optional protocolVersion property to the ApplicationTargetGroupProps, and writing a test to verify.

…Groups (#13570) Fixes #12869 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

github-actions · 2021-03-12T17:40:21Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/core](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/core) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/core's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/core's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/core">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/core&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [aws-cdk](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases">aws-cdk's releases</a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md">aws-cdk's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/aws-cdk">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=aws-cdk&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

[//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@aws-cdk/assert](https://github.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/assert) from 1.93.0 to 1.94.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/releases"><code>@aws-cdk/assert's releases</code></a>.</em></p> <blockquote> <h2>v1.94.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2>v1.94.0</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cdk/blob/master/CHANGELOG.md"><code>@aws-cdk/assert's changelog</code></a>.</em></p> <blockquote> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.94.0...v1.94.1">1.94.1</a> (2021-03-16)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>s3:</strong> Notifications fail to deploy due to incompatible node runtime (<a href="https://github.com/aws/aws-cdk/issues/13624">#13624</a>) (<a href="https://github.com/aws/aws-cdk/commit/26bc3d4951a96a4bdf3e3e10464a4e3b80ed563f">26bc3d4</a>)</li> </ul> <h2><a href="https://github.com/aws/aws-cdk/compare/v1.93.0...v1.94.0">1.94.0</a> (2021-03-16)</h2> <h3>⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES</h3> <ul> <li><strong>appmesh:</strong> Backend, backend default and Virtual Service client policies structures are being altered</li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualGateway</code>. The property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code></li> <li><strong>appmesh</strong>: you must use the backend default interface to define backend defaults in <code>VirtualNode</code>, (the property name also changed from <code>backendsDefaultClientPolicy</code> to <code>backendDefaults</code>), and the <code>Backend</code> class to define a backend</li> <li><strong>appmesh</strong>: you can no longer attach a client policy to a <code>VirtualService</code></li> </ul> <h3>Features</h3> <ul> <li><strong>appmesh:</strong> add missing route match features (<a href="https://github.com/aws/aws-cdk/issues/13350">#13350</a>) (<a href="https://github.com/aws/aws-cdk/commit/b71efd9d12843ab4b495d53e565cec97d60748f3">b71efd9</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11645">#11645</a></li> <li><strong>aws-elasticloadbalancingv2:</strong> add protocol version for ALB TargetGroups (<a href="https://github.com/aws/aws-cdk/issues/13570">#13570</a>) (<a href="https://github.com/aws/aws-cdk/commit/165a3d877b7ab23f29e42e1e74ee7c5cb35b7f24">165a3d8</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12869">#12869</a></li> <li><strong>ecs-patterns:</strong> Add ECS deployment circuit breaker support to higher-level constructs (<a href="https://github.com/aws/aws-cdk/issues/12719">#12719</a>) (<a href="https://github.com/aws/aws-cdk/commit/e80a98aa8839e9b9b89701158d82b991e9ebaa65">e80a98a</a>), closes <a href="https://github.com/aws/aws-cdk/issues/12534">#12534</a> <a href="https://github.com/aws/aws-cdk/issues/12360">#12360</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>appmesh:</strong> Move Client Policy from Virtual Service to backend structure (<a href="https://github.com/aws/aws-cdk/issues/12943">#12943</a>) (<a href="https://github.com/aws/aws-cdk/commit/d3f428435976c55ca950279cfc841665fd504370">d3f4284</a>), closes <a href="https://github.com/aws/aws-cdk/issues/11996">#11996</a></li> <li><strong>autoscaling:</strong> AutoScaling on percentile metrics doesn't work (<a href="https://github.com/aws/aws-cdk/issues/13366">#13366</a>) (<a href="https://github.com/aws/aws-cdk/commit/46114bb1f4702019a8873b9162d0a9f10763bc61">46114bb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13144">#13144</a></li> <li><strong>cloudwatch:</strong> cannot create Alarms from labeled metrics that start with a digit (<a href="https://github.com/aws/aws-cdk/issues/13560">#13560</a>) (<a href="https://github.com/aws/aws-cdk/commit/278029f25b41d956091835364e5a8de91429712c">278029f</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13434">#13434</a></li> <li>use NodeJS 14 for all packaged custom resources (<a href="https://github.com/aws/aws-cdk/issues/13488">#13488</a>) (<a href="https://github.com/aws/aws-cdk/commit/20a2820ee4d022663fcd0928fbc0f61153ae953f">20a2820</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13534">#13534</a> <a href="https://github.com/aws/aws-cdk/issues/13484">#13484</a></li> <li><strong>ec2:</strong> Security Groups support all protocols (<a href="https://github.com/aws/aws-cdk/issues/13593">#13593</a>) (<a href="https://github.com/aws/aws-cdk/commit/8c6b3ebea464e27f68ffcab32857d8baec29c413">8c6b3eb</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13403">#13403</a></li> <li><strong>lambda:</strong> fromDockerBuild output is located under /asset (<a href="https://github.com/aws/aws-cdk/issues/13539">#13539</a>) (<a href="https://github.com/aws/aws-cdk/commit/77449f61e7075fef1240fc52becb8ea60b9ea9ad">77449f6</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13439">#13439</a></li> <li><strong>region-info:</strong> ap-northeast-3 data not correctly registered (<a href="https://github.com/aws/aws-cdk/issues/13564">#13564</a>) (<a href="https://github.com/aws/aws-cdk/commit/64da84be5c60bb8132551bcc27a7ca9c7effe95d">64da84b</a>), closes <a href="https://github.com/aws/aws-cdk/issues/13561">#13561</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/aws/aws-cdk/commits/v1.94.1/packages/@aws-cdk/assert">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@aws-cdk/assert&package-manager=npm_and_yarn&previous-version=1.93.0&new-version=1.94.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

danilobuerger added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 4, 2021

github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Feb 4, 2021

github-actions bot assigned njlynch Feb 4, 2021

ChristopheBougere mentioned this issue Mar 12, 2021

feat(aws-elasticloadbalancingv2): add protocol version for ALB TargetGroups #13570

Merged

mergify bot closed this as completed in #13570 Mar 12, 2021

This was referenced Mar 17, 2021

chore(deps): Bump @aws-cdk/aws-s3 from 1.93.0 to 1.94.1 SnapPetal/cdk-simplewebsite-deploy#156

Closed

Bump aws-cdk from 1.76.0 to 1.94.1 covertbert/shared-aws-infra#143

Closed

dependabot bot mentioned this issue Mar 17, 2021

build(deps): bump @aws-cdk/core from 1.93.0 to 1.94.1 wheatstalk/oidc-mock#14

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(elasticloadbalancingv2): cant set protocol version on alb #12869

(elasticloadbalancingv2): cant set protocol version on alb #12869

danilobuerger commented Feb 4, 2021 •

edited

Loading

njlynch commented Feb 8, 2021

danilobuerger commented Feb 12, 2021

ChristopheBougere commented Mar 7, 2021

jesperrix commented Mar 12, 2021

njlynch commented Mar 12, 2021

github-actions bot commented Mar 12, 2021

(elasticloadbalancingv2): cant set protocol version on alb #12869

(elasticloadbalancingv2): cant set protocol version on alb #12869

Comments

danilobuerger commented Feb 4, 2021 • edited Loading

Reproduction Steps

What did you expect to happen?

What actually happened?

Environment

njlynch commented Feb 8, 2021

danilobuerger commented Feb 12, 2021

ChristopheBougere commented Mar 7, 2021

jesperrix commented Mar 12, 2021

njlynch commented Mar 12, 2021

github-actions bot commented Mar 12, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

danilobuerger commented Feb 4, 2021 •

edited

Loading