Support multiple scaling policies per scalable dimension #106
Conversation
surajkota
changed the title
|
/retest |
| "ack-sagemaker-execution-role", | ||
| "sagemaker.amazonaws.com", | ||
| managed_policies=[ | ||
| "arn:aws:iam::aws:policy/AmazonSageMakerFullAccess", |
There was a problem hiding this comment.
Is sagemaker and s3 fullaccess sufficient for autoscaling? Looks like that was what was there previously, but double-checking.
There was a problem hiding this comment.
yes. SageMakerFullAccess has all the permissions reqd for autoscaling
| @@ -90,7 +110,7 @@ deletionPolicy: delete | |||
| # controller reconciliation configurations | |||
| reconcile: | |||
| # The default duration, in seconds, to wait before resyncing desired state of custom resources. | |||
| defaultResyncPeriod: 0 | |||
There was a problem hiding this comment.
changed from latest code generator
There was a problem hiding this comment.
Are these changes part of new code-gen or added personally?
There was a problem hiding this comment.
changed from latest code generator
There was a problem hiding this comment.
A lot to follow, given there are code gen changes, updates to the testing framework and pending changes. I would have preferred we split these out, so that we can review each separately (and make it easier to revert if need be in the future).
Changes do seem to be pretty self explanatory, though
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RedbackThomson, ryansteakley, surajkota The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes: Release artifacts for `v1.0.6`. Fixes #106 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
Customer facing issue in using multiple scaling policies for a scalable dimension because originally the code assumed it is 1:1 mapping. To uniquely identify a scaling policy resource, we need policy name, resource-id, service namespace and scalable dimension. This PR adds ability to create multiple scaling policies per scalable dimension and also updates the following things:
PyYAMLdependency test-infra#368 issue while trying to fix the issue and cannot use latest ack-test without updating the bootstrap logicHit another issue described in aws-controllers-k8s/community#1871. Fix aws-controllers-k8s/code-generator#459 has been merged
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.