Implement ReadMany operation for SetSDK generator function

[brycahta]

Issue #, if available: #891

Description of changes:

• adds setSDKReadMany func to SetSDK
• adds unit test

Testing:

• make test ✅
• make build-controller ✅

// newListRequestPayload returns SDK-specific struct for the HTTP request
// payload of the List API call for the resource
func (rm *resourceManager) newListRequestPayload(
	r *resource,
) (*svcsdk.DescribeVpcsInput, error) {
	res := &svcsdk.DescribeVpcsInput{}

	if r.ko.Spec.DryRun != nil {
		res.SetDryRun(*r.ko.Spec.DryRun)
	}
	if r.ko.Status.VPCID != nil {
		f4 := []*string{}
		f4 = append(f4, r.ko.Status.VPCID)
		res.SetVpcIds(f4)
	}

	return res, nil
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-bot]

Hi @brycahta. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brycahta]

Refactor Opportunity

• There's duplicate logic between this ReadMany impl and the one done for CheckRequiredFields in this pr.
• I'd like to encapsulate this locating-and-matching-identifier logic as /pkg/generate/code/identifier.go (common.go will be deleted after moving helpers to this new file.)
• This set of helpers will not only help locate identifiers, but also match identifier fields between API Input Shape and a CRD model.
• Are there other areas in the project that reconcile complex data (i.e. comparing names and plurals) between API Input Shape and CRD?
• If so, please post details and we can see if a higher level abstraction would be more appropriate

[vijtrip2]

/ok-to-test

[vijtrip2]

• I'd like to encapsulate this locating-and-matching-identifier logic as /pkg/generate/code/identifier.go (common.go will be deleted after moving helpers to this new file.)

+1 . The less places we have the duplicated code the better because if a bug fix is needed in future, duplicated code may cause some places to be missed with the fix.

[vijtrip2]

Looks good to me. Just one very minor nit about unit test data.

[jaypipes]

I'm impressed with you digging into the code-generator like this, @brycahta. Well done. :)

I've left a couple comments inline for you to ponder.

[a-hilaly]

Awesome stuff! 👍

I Ieft few comments below

[brycahta]

• I'd like to encapsulate this locating-and-matching-identifier logic as /pkg/generate/code/identifier.go (common.go will be deleted after moving helpers to this new file.)

+1 . The less places we have the duplicated code the better because if a bug fix is needed in future, duplicated code may cause some places to be missed with the fix.

@vijtrip2 agreed. I will submit a separate refactor PR following the merge of this one

[vijtrip2]

Looks great!

[jaypipes]

Very nice work on this, @brycahta, thank you sir!

[jaypipes]

/lgtm

[ack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brycahta, jaypipes, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jaypipes,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment