Skip to content

use return statement instead of exit in is_public_ecr_logged_in #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021
Merged

use return statement instead of exit in is_public_ecr_logged_in #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/lib/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,12 @@ is_public_ecr_logged_in() {
local expiration_time=$(jq -r --arg url $public_ecr_url '.auths[$url].auth' ~/.docker/config.json | base64 -d | cut -d":" -f2 | base64 -d | jq -r ".expiration")

# If any part of this doesn't exist, the user isn't logged in
[ -z "$expiration_time" ] && exit 1
[ -z "$expiration_time" ] && return 1

local current_time=$(date +%s)

# If the credentials have expired, the user isn't logged in
[ "$expiration_time" -lt "$current_time" ] && exit 1
[ "$expiration_time" -lt "$current_time" ] && return 1

exit 0
return 0
}