Skip to content

Conversation

@RedbackThomson
Copy link
Contributor

@RedbackThomson RedbackThomson commented Oct 22, 2021

Description of changes:
This PR adds a Go template function for de-referencing strings. Go templates do not, out of the box, support string de-referencing when doing string comparison. When comparing a string pointer to a pointer it gives a fatal type mismatch error.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@vijtrip2 vijtrip2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,vijtrip2]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 18843e6 into aws-controllers-k8s:main Oct 22, 2021
@jaypipes
Copy link
Collaborator

Did we have an example where this was occurring? Or a GH issue that described the problem?

@RedbackThomson
Copy link
Contributor Author

Did we have an example where this was occurring? Or a GH issue that described the problem?

Sorry, I did not create a feature request to attach. The only description is the body of this PR. It's for changes to the S3 hook templates.

@RedbackThomson RedbackThomson deleted the dereference-helper branch October 25, 2021 17:11
@jaypipes
Copy link
Collaborator

Did we have an example where this was occurring? Or a GH issue that described the problem?

Sorry, I did not create a feature request to attach. The only description is the body of this PR. It's for changes to the S3 hook templates.

No need to apologize, @RedbackThomson, I was just curious where we were running into the fatal type mismatch thingie... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants