Added scheduling parameters to helm template; #249
Conversation
This adds affinity, toleration and priorityClassName to the deployment spec as optional parameters
ack-bot
added
the
needs-ok-to-test
|
Hi @philnichol. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
ack-bot
added
ok-to-test
|
/approve |
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
Nice! Thank you @philnichol!
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, philnichol, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available: Relates #249 Relates #252 Description of changes: This fixes a bug I introduced in a previous PR (sorry!) This must default to an empty string rather than null or you get: ``` Error: values don't meet the specifications of the schema(s) in the following chart(s): s3-chart: - deployment.priorityClassName: Invalid type. Expected: string, given: null ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
4 participants
Issue #, if available:
Closes #1038
Description of changes:
This adds affinity, toleration and priorityClassName to the deployment spec as optional parameters.
They default to none, so this will not change any existing functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.