allow iterating over a fieldpath's ShapeRefs #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
approved these changes
Dec 8, 2021
Member
|
/test s3-controller-test |
vijtrip2
reviewed
Dec 8, 2021
pkg/fieldpath/path.go
Outdated
| // At returns the part of the Path at the supplied index, or empty string if | ||
| // index exceeds boundary. | ||
| func (p *Path) At(index int) string { | ||
| if index < 0 || len(p.parts) < 0 || index > len(p.parts)-1 { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| if index < 0 || len(p.parts) < 0 || index > len(p.parts)-1 { | |
| if index < 0 || len(p.parts) == 0 || index > len(p.parts)-1 { |
Collaborator
Author
There was a problem hiding this comment.
doh. copy/pasta mistake on my part. nice catch! fixed.
pkg/fieldpath/path.go
Outdated
| // e.g. given Path $A containing "X.Y", $A.CopyAt(0) would return a new Path | ||
| // containing just "X". $A.CopyAt(1) would return a new Path containing "X.Y". | ||
| func (p *Path) CopyAt(index int) *Path { | ||
| if index < 0 || len(p.parts) < 0 || index > len(p.parts)-1 { |
Contributor
There was a problem hiding this comment.
nit: I think length function will never return less than 0. You can just check for empty i.e." == 0"
Suggested change
| if index < 0 || len(p.parts) < 0 || index > len(p.parts)-1 { | |
| if index < 0 || len(p.parts) == 0 || index > len(p.parts)-1 { |
Adds a few utility methods to `pkg/fieldpath.Path` to make it easier to inspect associated ShapeRefs at different parts of the path: * `Path.At(int)` returns the path part at the supplied index. * `Path.CopyAt(int)` returns a new Path up to the supplied index. * `Path.ShapeRefAt(*shapeRef, int)` returns a ShapeRef corresponding to the path part at the supplied index. * `Path.IterShapeRefs(*shapeRef)` returns a slice of *ShapeRef that can be used to iterate over the ShapeRefs associated with each of the Path's parts. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
force-pushed
the
iter-fieldpath
branch
from
90f8a04 to
928bd84
Compare
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few utility methods to
pkg/fieldpath.Pathto make it easier toinspect associated ShapeRefs at different parts of the path:
Path.At(int)returns the path part at the supplied index.Path.CopyAt(int)returns a new Path up to the supplied index.Path.ShapeRefAt(*shapeRef, int)returns a ShapeRef corresponding tothe path part at the supplied index.
Path.IterShapeRefs(*shapeRef)returns a slice of *ShapeRef that canbe used to iterate over the ShapeRefs associated with each of the
Path's parts.
Signed-off-by: Jay Pipes jaypipes@gmail.com
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.