always use single dot fieldpath notation #261
Conversation
This patch completes earlier work that was done in the `pkg/fieldpath` package that only uses a single dot notation to refer to a *field* with type *list* or *map* within a field path. We previously were using a double dot in field paths in `generator.yaml` config files to refer to fields of type list or map. This was erroneous, since referring to the *field* (not the *value* of the field) only requires a single dot in order for the fieldpath to "locate" a field within a path. In this PR, we simplify and DRY up the inference code in `pkg/model/model.go`'s processing of "nested fields" so that the field path added for all Field objects uses this single-dot notation only. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
vijtrip2
left a comment
vijtrip2
left a comment
There was a problem hiding this comment.
Much cleaner now. Like it! LGTM.
|
Just curious that if we need to refer to |
Maybe? I'd have to take a look at the code :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This patch completes earlier work that was done in the
pkg/fieldpathpackage that only uses a single dot notation to refer to a field with
type list or map within a field path.
We previously were using a double dot in field paths in
generator.yamlconfig files to refer to fields of type list or map. This was erroneous,
since referring to the field (not the value of the field) only
requires a single dot in order for the fieldpath to "locate" a field
within a path.
In this PR, we simplify and DRY up the inference code in
pkg/model/model.go's processing of "nested fields" so that the fieldpath added for all Field objects uses this single-dot notation only.
Signed-off-by: Jay Pipes jaypipes@gmail.com
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.