-
Notifications
You must be signed in to change notification settings - Fork 226
Add make targets for local builds
#297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement.
Any means of keeping the dependencies in go.local.mod and go.local.sum consistent with dependency updates in go.mod and go.sum.
Currently for code-generation, I just need to add a "replace" line in go.mod and just use existing make targets. With the new approach do you think there can be hidden surprises if go.local.mod and go.local.sum are not kept consistent.
Hmm yeah if any of the other direct dependencies are not updated in the |
|
/approve |
| @go build ${GO_TAGS} ${GO_LDFLAGS} -o bin/ack-generate cmd/ack-generate/main.go | ||
| @echo "ok." | ||
|
|
||
| local-build-ack-generate: ## Build ack-generate binary using the local go.mod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: using the file name is clearer, Build ack-generate binary using go.local.mod
|
I agree that keeping these 2 |
No doubt someone will commit this change and include it in a PR. I don't think our |
96f010b to
c5b0d06
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Adds a
go.local.mod, and make targets using the new file, to more easily reference the local runtime package. Developers are now able to runmake local-build-ack-generateto build and test changes tocode-generatorwhen updatingruntime.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.