Fix delta code generation for nested structs shapes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from test data from github.com/aws/aws-sdk-go commit 67f532fc99ebc262a50fa05500b3462065b75569
When generating and compiling the lambda controller delta code, i noticed few compilation errors, moslty about type mismatches between values and function parameters. This was due to a misplacement of the arugments passed to `code.compareSlice` and `code.compareMap` functions when they are called from `code.compareStruct`. This commit corrects the order/placement of arguments passed to the `compareSlice` and `compareMap` functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #29
Description of changes:
compareSliceandcompareMapfunctionsTestCompareResource_Lambda_CodeSigningConfigto test lambda code generationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.