Skip to content

Conversation

@a-hilaly
Copy link
Member

Issue #, if available:

Description of changes:

  • Pin ACK runtime to v0.20.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member Author

/test s3-controller-test

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 12, 2022

@a-hilaly: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
s3-controller-test 031353a link /test s3-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

discussed offline with @a-hilaly

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, brycahta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 2944c87 into aws-controllers-k8s:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants