Skip to content

Import names package from github.com/aws-controllers-k8s/pkg #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

Import names package from github.com/aws-controllers-k8s/pkg #366

merged 1 commit into from
Jan 24, 2023

Conversation

@a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Sep 15, 2022

Issue #, if available:

Description of changes:

  • Import names package from github.com/aws-controllers-k8s/pkg

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member Author

a-hilaly commented Sep 15, 2022

Awaiting on aws-controllers-k8s/pkg#6 (comment)

/hold

@ack-bot ack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2022
jaypipes
jaypipes approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bueno. will be even more bueno once we do proper semver releases of pkg/ repository

@a-hilaly
Copy link
Member Author

a-hilaly commented Sep 15, 2022

Thank you for the review @jaypipes . If you have a moment could you take a look at aws-controllers-k8s/pkg#6 (comment)

@ack-bot
Copy link
Collaborator

ack-bot commented Dec 14, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 13, 2023

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 13, 2023
@RedbackThomson
Copy link
Contributor

RedbackThomson commented Jan 18, 2023

Is this still a viable PR? @a-hilaly @jaypipes I know we still have duplication

@jaypipes
Copy link
Collaborator

jaypipes commented Jan 18, 2023

Is this still a viable PR? @a-hilaly @jaypipes I know we still have duplication

should be after a rebase, yeah.

@a-hilaly a-hilaly force-pushed the ack/pkg/names branch 2 times, most recently from 6e80065 to 99e945d Compare January 19, 2023 16:59
jaypipes
jaypipes approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Next step: semver release the pkg/ repo :)

@a-hilaly
Import names package from github.com/aws-controllers-k8s/pkg
aee428c 
Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
@a-hilaly
Copy link
Member Author

a-hilaly commented Jan 23, 2023 •
edited
Loading

PR Rebased and tests are passing now. PTAL @jaypipes @jljaco @RedbackThomson
Before making a semver release for ack/pkg I would like add add a few new initialisms to the names list (in a seperate PR)
/hold cancel

@ack-bot ack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2023
@a-hilaly a-hilaly removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 23, 2023
jaypipes
jaypipes approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍 from me.

jaypipes
jaypipes approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :)

@RedbackThomson
Copy link
Contributor

RedbackThomson commented Jan 24, 2023

Let's do it
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 7b72e0a into aws-controllers-k8s:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaypipes jaypipes jaypipes approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees

@RedbackThomson RedbackThomson

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a-hilaly @ack-bot @RedbackThomson @jaypipes