Return a terminal error when sdkUpdate is not implemented
#372
Conversation
|
This is expected to break some e2e tests in some controllers. |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
update/terminal-condition
branch
from
1eb464c to
5abe4e2
Compare
|
/test unit-test |
|
/retest |
1 similar comment
|
/retest |
|
/approve Let me know if you would like me to merge this |
|
@RedbackThomson yes, let's merge this. |
| latest *resource, | ||
| delta *ackcompare.Delta, | ||
| ) (*resource, error) { | ||
| // TODO(jaypipes): Figure this out... |
There was a problem hiding this comment.
You might even want to remove this comment now.
Currently the generated sdk code throws a simple error when `sdkUpdate` is not implemented. This is only observable in the controller logs and users are not able to read this information from their resource's status/conditions. This patch forces `sdkUpdate` to return a terminal error instead of a normal error. Fixes aws-controllers-k8s/community#1521 Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
a-hilaly
force-pushed
the
update/terminal-condition
branch
from
5abe4e2 to
2e58e5c
Compare
|
/unhold |
|
/hold cancel |
ack-bot
removed
the
do-not-merge/hold
|
@RedbackThomson @jaypipes i'm not sure but this PR can break few e2e tests for controllers relying on condition assertions.. we'll see.. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Nice, thx! |
5 participants
Currently the generated sdk code throws a simple error when
sdkUpdateis not implemented. This is only observable in the controller logs and
users are not able to read this information from their resource's
status/conditions.
This patch forces
sdkUpdateto return a terminal error instead of anormal error.
Fixes aws-controllers-k8s/community#1521
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.