handle renamed fields in SetResource generation #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple correction of a typo that was introduced way back when.
If fields were renamed in some operations, the code generated for `SetResource()` was not properly looking up the renamed field. This patch updates `SetResource()` to first check if the field has been renamed for the referred Operation and if so, look up the CRDField object in the CRD.SpecFields collection instead of the StatusFields collection.
|
Note to reviewers: I've included a unit test of this functionality, but also note that the RDS controller has been generated with this code and the DBSubnetGroup resource is properly handling renamed Name and Description fields for that resource. |
a-hilaly
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fields were renamed in some operations, the code generated for
SetResource()was not properly looking up the renamed field. Thispatch updates
SetResource()to first check if the field hasrenamed for the referred Operation and if so, look up the CRDField
object in the CRD.SpecFields collection instead of the StatusFields
collection.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.