Skip to content

Conversation

@RedbackThomson
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#729

Description of changes: Refactor MapStringStringEqual references to MapStringStringPEqual, so that it compares the string pointers rather than expecting pure strings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, @RedbackThomson thank you!

@jaypipes jaypipes merged commit df96615 into aws-controllers-k8s:main Mar 24, 2021
@RedbackThomson RedbackThomson deleted the fix-map-string-compare branch May 26, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants