Deterministic result order in GetImmutableFieldPaths
#405
Conversation
This patch addresses the issue of non-deterministic result order in the `GetImmutableFieldPath` function. In Go, maps and hashmaps accesss their elements randomly, which resulted in non-deterministic return arrays from `GetImmutableFieldPaths`. This patch leverages `sort.Strings` to ensure deterministic result order, ensuring deterministic behaviour in generated code. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
|
/lgtm |
|
@embano1: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
e2e tests will continue to fail until we make a new runtime release |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, embano1, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
This patch addresses the issue of non-deterministic result order in the
GetImmutableFieldPathfunction.In Go, maps and hashmaps access their elements randomly, which resulted
in non-deterministic return arrays from
GetImmutableFieldPaths. Thispatch leverages
sort.Stringsto ensure deterministic result order,ensuring deterministic behaviour in generated code.
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.