Skip to content

Conversation

@acornett21
Copy link
Contributor

Issue #, if available:

Description of changes:
Recently ControllerName was introduced to allow controllers to have a custom, more user friendly name. This change caused the /config/manifest/bases/<SPN>.yaml to be written to disk incorrectly for controllers that use the new ControllerName value. This change switches the /config/manifest/bases/<CN>.yaml to be written to disk so that OLM file/package generation can complete successfully and all of the proper values injected into the final /bundle.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…d `ControllerName`

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@ack-prow ack-prow bot requested review from jlbutler and jljaco February 16, 2024 18:28
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2024
@ack-prow
Copy link

ack-prow bot commented Feb 16, 2024

Hi @acornett21. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2024
@a-hilaly
Copy link
Member

documentdb tests are flaky.. investigating

@a-hilaly
Copy link
Member

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@ack-prow
Copy link

ack-prow bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, acornett21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Feb 16, 2024
@ack-prow ack-prow bot merged commit fd54e0f into aws-controllers-k8s:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants