feat(fieldpath): Handle case differences in structure member names #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ack-prow
bot
added
the
do-not-merge/work-in-progress
ack-prow
bot
added
approved
and removed
do-not-merge/work-in-progress
a-hilaly
force-pushed
the
case-insensitive-member-lookup
branch
from
205f270 to
8efc8b8
Compare
This patch updates the `memberShapeRef` function in the `fieldpath` package to handle case differences between struct member names in the ACK model and the AWS SDK Model. Previously, the function assumed that member names in the ACK model and AWS SDK model were identical. However, this is not always the case, as some field names may have different casing (e.g `AWSVPCConfiguration` in the ACK model and `AwsVpcConfiguration` in the AWS SDK model). To address this issue, the function now leverages `strings.EqualFold` to compare the member names case isensitively. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
a-hilaly
force-pushed
the
case-insensitive-member-lookup
branch
from
8efc8b8 to
d11714d
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jlbutler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
memberShapeReffunction in thefieldpathpackage to handle case differences between struct member names in the
ACK model and the AWS SDK Model.
Previously, the function assumed that member names in the ACK model and
AWS SDK model were identical. However, this is not always the case, as
some field names may have different casing (e.g
AWSVPCConfigurationinthe ACK model and
AwsVpcConfigurationin the AWS SDK model).To address this issue, the function now leverages
strings.EqualFoldtocompare the member names case isensitively.
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.