Add roleARN parameter to ManagerFor in resource manager factory
#540
Conversation
This commits upadtes the ManagerFor function generator in the resource manager factory to include the roleARN. The change also includes: - Updated `ManagerFor` function signature - Modified the rmId generation to incorporate `roleARN`, creating a unique identifier for each account/region/roleARN combination. - Update fake resource manager to match the new function signature
|
/retest |
|
@a-hilaly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, TiberiuGC The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
eks tests are flaky tonight, we'll give this a manual merge |
This commits upadtes the ManagerFor function generator in the
resource manager factory to include the roleARN. The change also
includes:
ManagerForfunction signatureroleARN, creatinga unique identifier for each account/region/roleARN combination.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.