Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CARM feature gates in Helm values template #546

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

a-hilaly
Copy link
Member

This patchh updates the feature gates configuration in the Helm values
template:

  • Removes the CARMv2 feature gate
  • Adds two new feature gates:
    • ServiceLevelCARM: Enables Service level granularity for CARM
    • TeamLevelCARM: Enables Team level granularity for CARM

Both new feature gates are set to false by default.

See aws-controllers-k8s/community#2031 for more
information on these CARM granularity levels.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This patchh updates the feature gates configuration in the Helm values
template:

- Removes the `CARMv2` feature gate
- Adds two new feature gates:
  - `ServiceLevelCARM`: Enables Service level granularity for CARM
  - `TeamLevelCARM`: Enables Team level granularity for CARM

Both new feature gates are set to `false` by default.

See aws-controllers-k8s/community#2031 for more
information on these CARM granularity levels.
@ack-prow ack-prow bot requested a review from jlbutler August 29, 2024 07:40
@ack-prow ack-prow bot added the approved label Aug 29, 2024
@a-hilaly a-hilaly changed the title Update CARM feature gates in Helm values template Update CARM feature gates in Helm values template Aug 29, 2024
Copy link

ack-prow bot commented Aug 29, 2024

@a-hilaly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-olm-test 506b3ba link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ack-prow bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, TiberiuGC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TiberiuGC TiberiuGC merged commit d22f9eb into aws-controllers-k8s:main Aug 29, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants