Skip to content

Conversation

@michaelhtm
Copy link
Member

Description of changes:
This change will allow us to include environment variable
for feature gates, specifically when testing specific ones

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This change will allow us to include environment variables
for feature gates, specifically when testing specific ones
@ack-prow ack-prow bot requested review from a-hilaly and jlbutler December 2, 2024 19:33
@michaelhtm
Copy link
Member Author

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@ack-prow
Copy link

ack-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 2, 2024
@michaelhtm
Copy link
Member Author

/retest

3 similar comments
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/retest

@ack-prow
Copy link

ack-prow bot commented Dec 2, 2024

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution eaa5341 link false /test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit ce8a66e into aws-controllers-k8s:main Dec 2, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants