Use ExportedName property of operation calls instead of Name #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <me@muvaf.com>
…lly match the name that can be used by other packages, otherwise Name can have API date in it, like it does for CloudFront Signed-off-by: Muvaffak Onus <me@muvaf.com>
Signed-off-by: Muvaffak Onus <me@muvaf.com>
jaypipes
reviewed
May 11, 2021
| // Hack to avoid import errors during build... | ||
| var ( | ||
| _ = &metav1.Time{} | ||
| _ = &aws.JSONValue{} |
Collaborator
There was a problem hiding this comment.
You won't need the ackv1alpha1 import, yes. But just double-check you won't need this one above...
Contributor
Author
There was a problem hiding this comment.
I think so. I double checked the repo.
Collaborator
There was a problem hiding this comment.
k, just double-checking :)
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaypipes, muvaf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Namecan return the name of the call with a date as we experienced inCloudFrontservice (likeGetDistribution2020_05_31WithContext). Tested this statement withrdsservice and no change was seen.I made the change in both ACK and Crossplane pipelines. It shouldn't affect the existing controllers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.