Don't match Status field when nil in ReadMany operation #609
Conversation
There was a problem hiding this comment.
out of scope for this PR, but something i wish set_resource did is evaluate "continuing/breaking" conditions the first. e.g
if name != x {
continue
}
if status.something != y {
continue
}
// we matched let's set the fields
...There was a problem hiding this comment.
Yeah having the matching field checks act as a guard clause would be more readable.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, knottnt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Update generated matching field check to fail on nil Status fields - Add test to verify generated output structure.
knottnt
force-pushed
the
read-many-status-nil-no-match
branch
from
580a56e to
13d54b5
Compare
|
@knottnt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@knottnt: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.