Skip to content

feat: reads enableCARM value and supplies to controller #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

feat: reads enableCARM value and supplies to controller #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1103242
feat: reads enableCARM value and supplies to controller if disabled
vjdandu Sep 16, 2025
4d16555
simplify logic and supply value always
vjdandu Sep 16, 2025
5d670d3
convert bool to string when supplying as env var
vjdandu Sep 16, 2025
ad989a7
supply directly to cli args instead of envvar
vjdandu Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/helm/templates/deployment.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ spec:
- --feature-gates
- "$(FEATURE_GATES)"
{{ "{{- end }}" }}
- {{ "--enable-carm={{ .Values.enableCARM }}" }}
image: {{ "{{ .Values.image.repository }}:{{ .Values.image.tag }}" }}
imagePullPolicy: {{ "{{ .Values.image.pullPolicy }}" }}
name: controller
Expand Down
5 changes: 5 additions & 0 deletions templates/helm/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@
},
"type": "object"
},
"enableCARM": {
"description": "Parameter to enable or disable cross account resource management.",
"type": "boolean",
"default": true
},
"serviceAccount": {
"description": "ServiceAccount settings",
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions templates/helm/values.yaml.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ leaderElection:
# pod.
namespace: ""

# Enable Cross Account Resource Management (default = true). Set this to false to disable cross account resource management.
enableCARM: true

# Configuration for feature gates. These are optional controller features that
# can be individually enabled ("true") or disabled ("false") by adding key/value
# pairs below.
Expand Down