Skip to content

Pin ACK runtime to v0.52.0 #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Pin ACK runtime to v0.52.0 #623

merged 1 commit into from
Sep 19, 2025

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Sep 18, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from jlbutler and rushmash91 September 18, 2025 16:49
@ack-prow ack-prow bot added the approved label Sep 18, 2025
@knottnt knottnt added the version/patch Indicates downstream controller releases should bump the patch version. label Sep 18, 2025
@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

@rushmash91 @michaelhtm @a-hilaly: Using version/patch.

a-hilaly
a-hilaly approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijaydandu
Copy link
Contributor

/retest

2 similar comments
@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/retest

@vijaydandu
Copy link
Contributor

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test cloudfront-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test prometheusservice-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test eks-controller-test

3 similar comments
@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test eks-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test eks-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test eks-controller-test

@vijaydandu
Copy link
Contributor

/test s3-olm-test

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 19, 2025 •
edited
Loading

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution db0256c link false /test verify-attribution
s3-olm-test db0256c link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor Author

knottnt commented Sep 19, 2025

/test eks-controller-test

@ack-prow ack-prow bot merged commit 6b42111 into aws-controllers-k8s:main Sep 19, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. version/patch Indicates downstream controller releases should bump the patch version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knottnt @vijaydandu @a-hilaly