Skip to content

Panic if input field renames are not part of a resource spec/status fields #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021
Merged

Panic if input field renames are not part of a resource spec/status fields #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/generate/code/set_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,16 +469,22 @@ func setResourceReadMany(
var targetMemberShapeRef *awssdkmodel.ShapeRef
targetAdaptedVarName := targetVarName
// Check that the field has potentially been renamed
renamedName, _ := r.InputFieldRename(
renamedName, foundInputFieldRename := r.InputFieldRename(
op.Name, memberName,
)
f, found = r.SpecFields[renamedName]
if found {
targetAdaptedVarName += cfg.PrefixConfig.SpecField
} else {
f, found = r.StatusFields[memberName]
f, found = r.StatusFields[renamedName]
if !found {
// TODO(jaypipes): check generator config for exceptions?
if foundInputFieldRename {
msg := fmt.Sprintf(
"Input field rename %s for operation %s is not part of %s Spec or Status fields",
memberName, op.Name, r.Names.Camel,
)
panic(msg)
}
continue
}
targetAdaptedVarName += cfg.PrefixConfig.StatusField
Expand Down Expand Up @@ -521,7 +527,7 @@ func setResourceReadMany(
// continue
// }
// }
if util.InStrings(memberName, matchFieldNames) {
if util.InStrings(renamedName, matchFieldNames) {
out += fmt.Sprintf(
"%s\t\tif %s.%s != nil {\n",
indent,
Expand Down