Add base CRD documentation #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Jun 15, 2021
jaypipes
approved these changes
Jun 15, 2021
Collaborator
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
well played, sir. well played.
| // Separate with a double newline to force a newline in the CRD base | ||
| docString += "\n//\n" + shape.Documentation | ||
| } | ||
| return docString |
Collaborator
There was a problem hiding this comment.
you may want to output a warning or something if there is no shape in the API.Shapes collection that matches the name of the resource...
Collaborator
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replaces the comment block for CRDs with the documentation of the resource shape from the AWS SDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.