ec2 transitgateway code-gen problem zz_conversions.go

[haarchri]

faced some problem in ec2 transitgateway during code-gen in crossplane project crossplane-contrib/provider-aws#831 in func GenerateModifyTransitGatewayInput

https://github.com/haarchri/provider-aws/blob/ec2-transitgateway/pkg/controller/ec2/transitgateway/zz_conversions.go#L209-L272

wrong:
cr.Spec.ForProvider.Options.AddTransitGatewayCIDRBlocks
cr.Spec.ForProvider.Options.AssociationDefaultRouteTableID
cr.Spec.ForProvider.Options.PropagationDefaultRouteTableID
cr.Spec.ForProvider.Options.RemoveTransitGatewayCIDRBlocks

correct:
cr.Spec.ForProvider.Options.TransitGatewayCIDRBlocks
cr.Spec.ForProvider.Options.DefaultRouteTableAssociation
cr.Spec.ForProvider.Options.DefaultRouteTablePropagation
cr.Spec.ForProvider.Options.TransitGatewayCIDRBlocks

crossplane-contrib/provider-aws#831
#489

[ack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[a-hilaly]

@haarchri Are you still experiencing the same issue? i see that https://github.com/haarchri/provider-aws/blob/ec2-transitgateway/pkg/controller/ec2/transitgateway/zz_conversions.go#L209-L272 got the correct field names

[haarchri]

@a-hilaly we skip the fields in generator-config - in general i think we have a problem with 4 fields:
https://github.com/haarchri/provider-aws/blob/ec2-transitgateway/apis/ec2/v1alpha1/generator-config.yaml#L86-L89

[a-hilaly]

/remove-lifecycle stale

[ack-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[a-hilaly]

@haarchri are you still experiencing this issue?

[ack-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

[vijtrip2]

Please reopen if this still blocks you