document Cluster Mode vs Namespace Mode RBAC #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Feb 14, 2022
| [s3-ecr-chart]: https://gallery.ecr.aws/aws-controllers-k8s/s3-chart | ||
|
|
||
| Before installing a Helm chart, you must first make the Helm chart available on the `Deployment` host. To do so, use the `helm pull` command and then extract the chart: | ||
| Before installing a Helm chart, you must first make the Helm chart available on the dDeployment host. To do so, use the `helm pull` command and then extract the chart: |
Member
There was a problem hiding this comment.
nit:
Suggested change
| Before installing a Helm chart, you must first make the Helm chart available on the dDeployment host. To do so, use the `helm pull` command and then extract the chart: | |
| Before installing a Helm chart, you must first make the Helm chart available on the Deployment host. To do so, use the `helm pull` command and then extract the chart: |
Member
|
Neat and clear! |
Adds explanation in the authorization.md document about the difference between Cluster Mode and Namespace Mode when starting an ACK controller including language that describes the various ClusterRole or Role permissions required for controllers started in either mode. Issue: aws-controllers-k8s#1173 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
acornett21
approved these changes
Feb 14, 2022
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, acornett21, jaypipes, RedbackThomson, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jaypipes
added a commit
to jaypipes/ack-code-generator
that referenced
this pull request
Feb 15, 2022
This is the patch that corresponds to changes made to ACK runtime to rename the `K8S_NAMESPACE` environment variable to `ACK_SYSTEM_NAMESPACE` to better represent what this variable referred to. Related: aws-controllers-k8s/runtime#72 Related: aws-controllers-k8s/community#1178 Issue: aws-controllers-k8s/community#1173 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
added a commit
to jaypipes/ack-code-generator
that referenced
this pull request
Feb 15, 2022
This is the patch that corresponds to changes made to ACK runtime to rename the `K8S_NAMESPACE` environment variable to `ACK_SYSTEM_NAMESPACE` to better represent what this variable referred to. Related: aws-controllers-k8s/runtime#72 Related: aws-controllers-k8s/community#1178 Issue: aws-controllers-k8s/community#1173 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
jaypipes
added a commit
to jaypipes/ack-code-generator
that referenced
this pull request
Feb 15, 2022
This is the patch that corresponds to changes made to ACK runtime to rename the `K8S_NAMESPACE` environment variable to `ACK_SYSTEM_NAMESPACE` to better represent what this variable referred to. Related: aws-controllers-k8s/runtime#72 Related: aws-controllers-k8s/community#1178 Issue: aws-controllers-k8s/community#1173 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
ack-bot
pushed a commit
to aws-controllers-k8s/code-generator
that referenced
this pull request
Feb 15, 2022
This is the patch that corresponds to changes made to ACK runtime to rename the `K8S_NAMESPACE` environment variable to `ACK_SYSTEM_NAMESPACE` to better represent what this variable referred to. Related: aws-controllers-k8s/runtime#72 Related: aws-controllers-k8s/community#1178 Issue: aws-controllers-k8s/community#1173 Signed-off-by: Jay Pipes <jaypipes@gmail.com> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explanation in the authorization.md document about the difference
between Cluster Mode and Namespace Mode when starting an ACK controller
including language that describes the various ClusterRole or Role
permissions required for controllers started in either mode.
Issue: #1173
Signed-off-by: Jay Pipes jaypipes@gmail.com
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.