Skip to content

Add TableReplicas Support for DynamoDB Table Replicas #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2025
Merged

Add TableReplicas Support for DynamoDB Table Replicas #120

merged 5 commits into from
Mar 25, 2025

Conversation

@rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Mar 13, 2025 •
edited
Loading

fixes aws-controllers-k8s/community#2077

This PR implements support for managing DynamoDB table replicas through the tableReplicas field. This enhancement allows users to manage multi-region table replicas that automatically remain in sync. This is complemented by a replicaDescription field in the Table status for tracking replica states.

Changes Overview

  • Added tableReplicas field to Table spec for defining replica configurations across regions
  • Added controller logic for replica lifecycle management (creation, updates, deletion)
  • Implemented validation rules:
    • DynamoDB Streams must be enabled with NEW_AND_OLD_IMAGES
    • Terminal error conditions for invalid configurations
  • E2E tests

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 13, 2025 23:00
@ack-prow ack-prow bot added the approved label Mar 13, 2025
@rushmash91 rushmash91 force-pushed the main branch 6 times, most recently from ca89ad3 to b53e944 Compare March 17, 2025 17:18
@rushmash91 rushmash91 changed the title add replica update support add replica support dynamoDB tables Mar 17, 2025
a-hilaly
a-hilaly reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 !

@rushmash91 rushmash91 force-pushed the main branch 11 times, most recently from f42a7c9 to 81e1cbd Compare March 21, 2025 07:50
@rushmash91 rushmash91 force-pushed the main branch 2 times, most recently from 0185830 to 75da9b2 Compare March 21, 2025 19:01
@rushmash91 rushmash91 changed the title add replica support dynamoDB tables Add ReplicationGroup Support for DynamoDB Table Replicas Mar 21, 2025
a-hilaly
a-hilaly reviewed Mar 21, 2025
View reviewed changes
@rushmash91 rushmash91 force-pushed the main branch 4 times, most recently from 5cdbb69 to 72c06f0 Compare March 24, 2025 02:23
a-hilaly
a-hilaly reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close!

@rushmash91 rushmash91 force-pushed the main branch 10 times, most recently from c6facdd to 0550f7a Compare March 24, 2025 23:14
a-hilaly
a-hilaly approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @rushmash91 !

michaelhtm
michaelhtm reviewed Mar 25, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this one @rushmash91 🚀
left a few nits

@ack-prow
Copy link

ack-prow bot commented Mar 25, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dynamodb-verify-attribution 652f3f4 link false /test dynamodb-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

michaelhtm
michaelhtm approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rushmash91 🚀
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@ack-prow
Copy link

ack-prow bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 755ecd8 into aws-controllers-k8s:main Mar 25, 2025
6 of 7 checks passed
michaelhtm added a commit to michaelhtm/ack-dynamodb-controller that referenced this pull request Mar 27, 2025
@michaelhtm
Revert "Add TableReplicas Support for DynamoDB Table Replicas (aws-…
ebf4803 
…controllers-k8s#120)"

This reverts commit 755ecd8.
michaelhtm added a commit to michaelhtm/ack-dynamodb-controller that referenced this pull request Mar 27, 2025
@michaelhtm
Revert "Add TableReplicas Support for DynamoDB Table Replicas (aws-co…
7b6a0d0 
…ntrollers-k8s#120)

This reverts commit 755ecd8.
Ensure we keep the field in helm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@michaelhtm michaelhtm michaelhtm approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@michaelhtm michaelhtm

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for DynamoDB Global Table V2 (2019.11.21)

3 participants

@rushmash91 @a-hilaly @michaelhtm