Skip to content

add TableReplica field #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ack-prow merged 1 commit into from
Mar 28, 2025
Merged

add TableReplica field #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ack_generate_info:
build_date: "2025-03-27T16:23:51Z"
build_date: "2025-03-28T01:43:12Z"
build_hash: 980cb1e4734f673d16101cf55206b84ca639ec01
go_version: go1.24.1
version: v0.44.0
Expand Down
39 changes: 20 additions & 19 deletions pkg/resource/table/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package table

import (
"context"
"errors"
"fmt"
"strings"
"time"
Expand Down Expand Up @@ -232,17 +233,17 @@ func (rm *resourceManager) customUpdateTable(
}
return nil, err
}
// case delta.DifferentAt("Spec.TableReplicas"):
// // Enabling replicas required streams enabled and StreamViewType to be NEW_AND_OLD_IMAGES
// // Version 2019.11.21 TableUpdate API requirement
// if !hasStreamSpecificationWithNewAndOldImages(desired) {
// msg := "table must have DynamoDB Streams enabled with StreamViewType set to NEW_AND_OLD_IMAGES for replica updates"
// rlog.Debug(msg)
// return nil, ackerr.NewTerminalError(errors.New(msg))
// }
// if err := rm.syncReplicas(ctx, latest, desired); err != nil {
// return nil, err
// }
case delta.DifferentAt("Spec.TableReplicas"):
// Enabling replicas required streams enabled and StreamViewType to be NEW_AND_OLD_IMAGES
// Version 2019.11.21 TableUpdate API requirement
if !hasStreamSpecificationWithNewAndOldImages(desired) {
msg := "table must have DynamoDB Streams enabled with StreamViewType set to NEW_AND_OLD_IMAGES for replica updates"
rlog.Debug(msg)
return nil, ackerr.NewTerminalError(errors.New(msg))
}
if err := rm.syncReplicas(ctx, latest, desired); err != nil {
return nil, err
}
}
}

Expand Down Expand Up @@ -577,14 +578,14 @@ func customPreCompare(
}
}

// // Handle ReplicaUpdates API comparison
// if len(a.ko.Spec.TableReplicas) != len(b.ko.Spec.TableReplicas) {
// delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
// } else if a.ko.Spec.TableReplicas != nil && b.ko.Spec.TableReplicas != nil {
// if !equalReplicaArrays(a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas) {
// delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
// }
// }
// Handle ReplicaUpdates API comparison
if len(a.ko.Spec.TableReplicas) != len(b.ko.Spec.TableReplicas) {
delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
} else if a.ko.Spec.TableReplicas != nil && b.ko.Spec.TableReplicas != nil {
if !equalReplicaArrays(a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas) {
delta.Add("Spec.TableReplicas", a.ko.Spec.TableReplicas, b.ko.Spec.TableReplicas)
}
}

if a.ko.Spec.DeletionProtectionEnabled == nil {
a.ko.Spec.DeletionProtectionEnabled = aws.Bool(false)
Expand Down
Loading