Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-06-10T23:41:29Z"
build_hash: e675923dfc54d8b6e09730098c3e3e1056d3c1e9
go_version: go1.24.3
version: v0.48.0
build_date: "2025-07-15T01:30:17Z"
build_hash: 4640e4fbac38e133c51fc9a0c2ff49e57b1a4d13
go_version: go1.24.4
version: v0.48.0-4-g4640e4f
api_directory_checksum: bcdceff2d7ddf7c98141572260ef2e6cee8bf23f
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
Expand Down
4 changes: 0 additions & 4 deletions pkg/resource/table/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,6 @@ func (rm *resourceManager) setResourceAdditionalFields(
} else {
ko.Spec.ContinuousBackups = pitrSpec
}

if err = rm.setContributorInsights(ctx, ko); err != nil {
return err
}
return nil
}

Expand Down
21 changes: 9 additions & 12 deletions pkg/resource/table/sdk.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 3 additions & 10 deletions templates/hooks/table/sdk_create_post_set_output.go.tpl
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
if desired.ko.Spec.TimeToLive != nil {
if err := rm.syncTTL(ctx, desired, &resource{ko}); err != nil {
return nil, err
}
}

if desired.ko.Spec.ContributorInsights != nil {
if err := rm.updateContributorInsights(ctx, desired); err != nil {
return nil, err
}
// handle in sdkUpdate, to give resource time until it creates
if desired.ko.Spec.TimeToLive != nil || desired.ko.Spec.ContributorInsights != nil {
ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil)
}
8 changes: 6 additions & 2 deletions templates/hooks/table/sdk_read_one_post_set_output.go.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,13 @@
if !canUpdateTableGSIs(&resource{ko}) {
return &resource{ko}, requeueWaitGSIReady
}
if err := rm.setResourceAdditionalFields(ctx, ko); err != nil {
return nil, err
if err = rm.setContributorInsights(ctx, ko); err != nil {
return &resource{ko}, err
}
if isTableUpdating(&resource{ko}) || isTableContributorInsightsUpdating(&resource{ko}) {
return &resource{ko}, requeueWaitWhileUpdating
}

if err := rm.setResourceAdditionalFields(ctx, ko); err != nil {
return nil, err
}