fix(network_acl): Preserve desired entries order after update #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses an issue where the EC2 API may return entries in a different order than specified. Causing the controller to go change the desired state spec. Now, after updating the NACL, we fetch the latest resource status but we preserve the order of entries.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nnbu
pushed a commit
to nnbu/ack-ec2-controller
that referenced
this pull request
Sep 18, 2024
…ntrollers-k8s#208) This patch addresses an issue where the EC2 API may return entries in a different order than specified. Causing the controller to go change the desired state spec. Now, after updating the NACL, we fetch the latest resource status but we preserve the order of entries. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue where the EC2 API may return entries
in a different order than specified. Causing the controller to go
change the desired state spec.
Now, after updating the NACL, we fetch the latest resource status
but we preserve the order of entries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.