Ensure Ref is not overwritten in Spec

Similarly as the ec2-controller, the ref stored in a struct
is being overwritten during create/update. With this fix
we ensure the ref would not be discarded.

Currently there isn't a way to test this fix, as we can't
run two controllers simultaneously and reference subnet names
in cluster directly.
Instead I will document an example with the fix working in
this PR

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,7 +1,7 @@
 ack_generate_info:
-  build_date: "2024-08-29T17:14:13Z"
+  build_date: "2024-09-18T21:03:40Z"
   build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
-  go_version: go1.22.5
+  go_version: go1.23.0
   version: v0.38.1
 api_directory_checksum: 626700f8799840e0470b1ff7ef3dbb32665b9f9d
 api_version: v1alpha1

pkg/resource/cluster/hook.go

@@ -322,6 +322,13 @@ func (rm *resourceManager) customUpdate(
 	}
 
 	rm.setStatusDefaults(updatedRes.ko)
+	if desired.ko.Spec.ResourcesVPCConfig.SubnetRefs != nil {
+		updated.ko.Spec.ResourcesVPCConfig.SubnetRefs = desired.ko.Spec.ResourcesVPCConfig.SubnetRefs
+	}
+
+	if desired.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs != nil {
+		updated.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs = desired.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs
+	}
 	return updatedRes, nil
 }
 

templates/hooks/cluster/sdk_create_post_set_output.go.tpl

@@ -6,3 +6,11 @@
 		ackcondition.SetSynced(&resource{ko}, corev1.ConditionFalse, nil, nil)
 		return &resource{ko}, nil
 	}
+
+	if desired.ko.Spec.ResourcesVPCConfig.SubnetRefs != nil {
+		ko.Spec.ResourcesVPCConfig.SubnetRefs = desired.ko.Spec.ResourcesVPCConfig.SubnetRefs
+	}
+
+	if desired.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs != nil {
+		ko.Spec.ResourcesVPCConfig.SecurityGroupRefs = desired.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs
+	}

templates/hooks/cluster/sdk_read_one_post_set_output.go.tpl

@@ -6,3 +6,10 @@
 		ackcondition.SetSynced(&resource{ko}, corev1.ConditionTrue, nil, nil)
 	}
 
+	if r.ko.Spec.ResourcesVPCConfig.SubnetRefs != nil {
+		ko.Spec.ResourcesVPCConfig.SubnetRefs = r.ko.Spec.ResourcesVPCConfig.SubnetRefs
+	}
+
+	if r.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs != nil {
+		ko.Spec.ResourcesVPCConfig.SecurityGroupRefs = r.ko.Spec.ResourcesVPCConfig.SecurityGroupRefs
+	}