Include additional keys to adopt identityProviderConfig
#136
Conversation
michaelhtm
force-pushed
the
identity-adoption
branch
from
9066e14 to
eebb52d
Compare
This change ensures users are required to provide an identityProviderConfigName when adopting the resource, as it is a required input field. Not sure if we should change that to the primary NameOrID, and make clusterName and additional Key..
michaelhtm
force-pushed
the
identity-adoption
branch
from
eebb52d to
6f3bdf8
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2193
Description of changes:
This change ensures users are required
to provide an
identityProviderConfigNamewhen adopting the resource, as it is a required
input field.
Not sure if we should change that to the primary
NameOrID, and makeclusterNamean additional Key..By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.