Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.40.0, code-generator v0.40.0 #140

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 9, 2024

Update to ACK runtime v0.40.0, code-generator v0.40.0



NOTE:
This PR increments the release version of service controller from v1.5.2 to v1.5.3

Once this PR is merged, release v1.5.3 will be automatically created for eks-controller

Please close this PR, if you do not want the new patch release for eks-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building eks-controller ====
Copying common custom resource definitions into eks
Building Kubernetes API objects for eks
Generating deepcopy code for eks
Generating custom resource definitions for eks
Building service controller for eks
Generating RBAC manifests for eks
Running gofmt against generated code for eks
Updating additional GitHub repository maintenance files
==== building eks-controller release artifacts ====
Building release artifacts for eks-v1.5.3
Generating common custom resource definitions
Generating custom resource definitions for eks
Generating RBAC manifests for eks

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Dec 9, 2024
@ack-prow ack-prow bot requested review from a-hilaly and mikestef9 December 9, 2024 17:24
@a-hilaly
Copy link
Member

/lgtm
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Dec 16, 2024
@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link

ack-prow bot commented Dec 16, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-verify-attribution 7c79574 link false /test eks-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
Copy link

ack-prow bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@ack-prow ack-prow bot merged commit 4025626 into main Dec 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants