Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in ACK common controller files #1

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

a-hilaly
Copy link
Member

Description of changes:

Aligns to the readme/docs used from other ACK service controller
repositories and a generator.yaml that ignores all resources in MemoryDB.

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

Aligns to the readme/docs used from other ACK service controller
repositories and a generator.yaml that ignores all resources in MemoryDB.
@vijtrip2
Copy link

/approve

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2021
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's get this repo and controller added to our CI lists please. Merging manually.

@ack-bot
Copy link
Collaborator

ack-bot commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes, RedbackThomson, vijtrip2

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaypipes jaypipes merged commit 6a8810f into aws-controllers-k8s:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants