Support for User, ACL, SubnetGroup #11
Conversation
nmvk
force-pushed
the
aclsubnet
branch
2 times, most recently
from
401b400 to
074eb0f
Compare
User Support for secret Re-queue logic to fix correct status E2E Tests Support for determining correct access string change. ACL E2E Tests using User Re-queue logic to fix correct status E2E framework updated to create other MemoryDB resources in test. SubnetGroup E2E Tests Determine correct subnets for E2E tests New bootstrap-able data to get correct memory db specific subnets.
| terminal_codes: | ||
| - ACLAlreadyExistsFault | ||
| - DefaultUserRequired | ||
| - UserNotFoundFault |
There was a problem hiding this comment.
nit: recommended to remove NotFound errors from terminal code because referencing resources it is usual to see NotFound error while referenced resource is being created
| @@ -0,0 +1,16 @@ | |||
| var resourceSyncedCondition *ackv1alpha1.Condition = nil | |||
There was a problem hiding this comment.
nit: You should not be needing Custom hook for setting Synced condition. If there are no errors and this condition will set to true by default at the end of reconciliation loop. If you want to control it then you can use SyncedConfig inside generator.yaml.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kumargauravsharma, nmvk, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
User
ACL
SubnetGroup
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.