Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ACK runtime v0.20.1, code-generator v0.20.1 #30

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Sep 12, 2022

Update to ACK runtime v0.20.1, code-generator v0.20.1



NOTE:
This PR increments the release version of service controller from v0.0.2 to v0.0.3

Once this PR is merged, release v0.0.3 will be automatically created for memorydb-controller

Please close this PR, if you do not want the new patch release for memorydb-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building memorydb-controller ====
Copying common custom resource definitions into memorydb
Building Kubernetes API objects for memorydb
Generating deepcopy code for memorydb
Generating custom resource definitions for memorydb
Building service controller for memorydb
Generating RBAC manifests for memorydb
Running gofmt against generated code for memorydb
Updating additional GitHub repository maintenance files
==== building memorydb-controller release artifacts ====
Building release artifacts for memorydb-v0.0.3
Generating common custom resource definitions
Generating custom resource definitions for memorydb
Generating RBAC manifests for memorydb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Nov 4, 2022

/retest

3 similar comments
@a-hilaly
Copy link
Member

a-hilaly commented Nov 7, 2022

/retest

@a-hilaly
Copy link
Member

a-hilaly commented Nov 9, 2022

/retest

@a-hilaly
Copy link
Member

/retest

ack-bot pushed a commit that referenced this pull request Nov 24, 2022
Issue #, if available:
Fixes e2e test failure in #30 
Description:
Test file cluster_memory_validations.yaml has error:
`ERROR    root:resource.py:330 Wait for condition ACK.ResourceSynced to reach status True timed out`
Which occurs at step "PERFORM_SCALE_UP_AND_SCALE_IN".

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@kyriechen96
Copy link
Contributor

/retest

1 similar comment
@kyriechen96
Copy link
Contributor

/retest

@RedbackThomson
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@ack-bot
Copy link
Collaborator Author

ack-bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 8a0bc12 into main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants