Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate controller using code-generator @ gc1f00b5 #35

Merged

Conversation

kyriechen96
Copy link
Contributor

@kyriechen96 kyriechen96 commented Dec 6, 2022

Issue #, if available:
Controller cannot compile well with current Tags.go file.

Description of changes:
Uses latest code-generator(gc1f00b5) to regenerate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from jaypipes and nmvk December 6, 2022 01:34
@kyriechen96
Copy link
Contributor Author

/retest

@kyriechen96 kyriechen96 changed the title Updates by new code-generator. Regenerate controller using code-generator @ gc1f00b5 Dec 6, 2022
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you @kyriechen96 !
/approve
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, kyriechen96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 9a04058 into aws-controllers-k8s:main Dec 6, 2022
kyriechen96 added a commit to kyriechen96/memorydb-controller that referenced this pull request Dec 8, 2022
…s-k8s#35)

Issue #, if available:
Controller cannot compile well with current Tags.go file.

Description of changes:
Uses latest code-generator(gc1f00b5) to regenerate.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants