Ignore ClusterName for copySnapshot API #58
Conversation
| @@ -209,6 +209,7 @@ resources: | |||
| path: SourceSnapshotName | |||
| ClusterName: | |||
| is_primary_key: false | |||
| is_required: false | |||
There was a problem hiding this comment.
I don't see any changes to the API file which I would expect to see if this worked
There was a problem hiding this comment.
Hopefully it could work
There was a problem hiding this comment.
I think I understand - the v0.23.1 code-generator fixed a bug where we weren't properly setting required on fields that were imported as custom. Because we now are, and this field was required, it was marking it as such even though we don't want it to be. So setting the is_required manually suppresses that. 👍🏼
|
/retest |
kyriechen96
force-pushed
the
fix_copysnapshot
branch
from
ec2dd05 to
85f37b5
Compare
|
/lgtm |
1 similar comment
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyriechen96, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
v0.23.1 code-controller considers ClusterName as required field for snapshot, but memorydb copySnapshot API should have empty ClusterName.
Description of changes:
Set is_required value of ClusterName to false for snapshot.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.