Add new condition ACK.Advisory #17
Conversation
|
/assign @vijtrip2 |
apis/core/v1alpha1/conditions.go
Outdated
| // ConditionTypeWarning indicates any warning that may be present in the resource. | ||
| // Examples include | ||
| // - Modifying an immutable field after it was created | ||
| ConditionTypeWarning ConditionType = "ACK.Warning" |
There was a problem hiding this comment.
I actually would prefer to call this ConditionTypeInfo or ConditionTypeAdvisory instead of ConditionTypeWarning. The word "warning" is generally reserved for serious things that should be addressed ASAP by an operator. In the case of an immutable field being modified in the Spec of a resource, that's definitely not something that needs to be addressed ASAP by an operator (since it's not dangerous or anything)
There was a problem hiding this comment.
Changed this to ConditionTypeAdvisory as someone may ignore ConditionTypeInfo without noticing
New condition ACK.Warning to set the condition when any immutable field is modified.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, nmvk, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New condition ACK.Advisory to set the condition when any immutable field is modified. This is needed for aws-controllers-k8s/code-generator#70
5 participants
New condition ACK.Advisory to set the condition
when any immutable field is modified.
This is needed for aws-controllers-k8s/code-generator#70