feat: adds EnableCARM flag to prevent watching namespaces in ns scope

[vijaydandu]

fixes aws-controllers-k8s/community#2625

Description of changes:

• adds explicit EnableCARM flag to enable/disable Cross Account Resource Management

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

Hi @vijaydandu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[vijaydandu]

/retest

[a-hilaly]

Neat, thank you @vijaydandu ! i have one comment below

[a-hilaly]

i'm not opposed to this, but if you want to allow users to enable CARM even when they're on single namespace mode, should we update the comment above?

[vijaydandu]

That totally makes sense. I have updated it to match the change.

[vijaydandu]

/retest

[vijaydandu]

/retest

[ack-prow]

@vijaydandu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
verify-attribution	a11c748	link	false	/test verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[a-hilaly]

Thank you @vijaydandu !

/cc @rushmash91 @michaelhtm @knottnt

[tomreece]

Would it be worthwhile to name the new flag without an acronym to avoid confusion? Or does everyone know what CARM is?

enable-cross-account-resource-management

There are already some other long flag names, like reconcile-resource-max-concurrent-syncs and enable-adopted-resource-reconciler so even though my suggested name is long, at least it's explicit.

What do you think @vijaydandu ?

[vijaydandu]

Would it be worthwhile to name the new flag without an acronym to avoid confusion? Or does everyone know what CARM is?

enable-cross-account-resource-management

There are already some other long flag names, like reconcile-resource-max-concurrent-syncs and enable-adopted-resource-reconciler so even though my suggested name is long, at least it's explicit.

What do you think @vijaydandu ?

While I am not opposed to it, I like it to be short and crisp. Also, the docs already popularized the acronym. Will leave it to @a-hilaly's discretion.

[rushmash91]

this looks good to me, thanks @vijaydandu !
/lgtm

[ack-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, rushmash91, vijaydandu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [a-hilaly,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment